Offset analysis updates #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add to README and CHANGELOG
Carsonthemonkey
approved these changes
Jun 6, 2024
bcipy/helpers/offset.py
Outdated
| if recommend_static: | ||
| # test for normality | ||
| _, p_value = normaltest(diffs) | ||
| print(f'{describe(diffs)}') |
There was a problem hiding this comment.
Is the f-string necessary here?
lawhead
approved these changes
Jun 6, 2024
Add new tests, use the stim number to determine how many stimuli before skipping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add support for determining offsets between timing verification Tasks (Ex. RSVPTimingVerificationCalibration) and RawData with a photodiode trigger column. This is useful for setting up new systems and preventing errors before an experiment begins.
Ticket
Contributions
Test
make test-allmake offsetmake offset-recommendDocumentation
Changelog