Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task registry refactor #332

Merged
merged 37 commits into from
Jul 18, 2024
Merged

Task registry refactor #332

merged 37 commits into from
Jul 18, 2024

Conversation

Carsonthemonkey
Copy link
Collaborator

Overview

Refactor the task registry to automatically collect tasks. This ensures there is a single source of truth for string references to tasks.

Ticket

Pivotal Ticket

Contributions

  • Adds TaskRegistry class
  • Dynamically collect non-abstract subclasses of Task
  • Refactor BaseCalibrationTask to be abstract
  • Refactor task name property to work on base type
  • Remove TaskType

Test

  • Refactor existing task tests to use and test the registry

Documentation

  • Inline comments have been added to module __init__ .py files

Changelog

Changelog updated.

Carsonthemonkey and others added 30 commits June 13, 2024 13:36
@Carsonthemonkey
refactors name property of tasks
7c30b33
@Carsonthemonkey
Adds task registry class
c0da1a5
@Carsonthemonkey
changes action names to have spaces
62fbd70
@Carsonthemonkey
Updates task_registry.py to import all tasks
7fb923f
@Carsonthemonkey
removes super calls to abstract method execute
082f5c7
@Carsonthemonkey
Filters out abstract subclasses from registry generation
a48e766
@Carsonthemonkey
removes registry dict empty initialization
9c2f1b6
@Carsonthemonkey
Fixes typing issues
7df1c1a
@Carsonthemonkey
Removes task import from registry
d995939
@Carsonthemonkey
Merge branch 'session-orchestrator' into task_registry_refactor
c9fd9bf
@Carsonthemonkey
Refactors config to support TaskRegistry
686715e
@Carsonthemonkey
Refactors task names
8f0c9aa
@Carsonthemonkey
Fixes failing tests and adds string formatting test
8d41424
@Carsonthemonkey
lints code
adc2282
@Carsonthemonkey
Removes unused imports
6b2b835
@Carsonthemonkey
Removes unused imports
e7ae99d
@Carsonthemonkey
Fixes formatting and typing congflicy
cdc61b0
@Carsonthemonkey
Merge branch '2.0.0rc4' into task_registry_refactor
0ab420d
@Carsonthemonkey
Refactors TaskRegistry to recursively collect subclasses
dfe9558 
This makes it compatible with the new `BaseCalibrationTask` as it will be able to collect grandchild classes of `Task` (which is all calibration tasks now)
@Carsonthemonkey
ignores type error with subclass collection
5674fd8
@Carsonthemonkey
Makes BaseCalibrationTask abstract
25b50d5 
This allows the TaskRegistry to properly filter it out, and will throw errors if instantiation is attempted
@Carsonthemonkey
removes name and label from timing_verification.py
4c6e601
@Carsonthemonkey
lints code
8f8d2ea
@Carsonthemonkey
imports tasks in their module's __init__.py
4cc7f5d 
This makes all tasks available to the task registry when it is initialized
@Carsonthemonkey
Enforces name attribute in base task class
cc0184b
@Carsonthemonkey
removes unnecessary f-string
f6eff2c
@tab-cmd
change import strategy, ignore lint errors, start updating main
841bbe8
@Carsonthemonkey
adds calibration task check to registry
2022de6
@Carsonthemonkey
fixes types and method calls in main
1ea1a2c 
TaskType now no longer exists
@Carsonthemonkey
fixes incorrect method name in TaskRegistry
1c6ccb0
@Carsonthemonkey
Copy link
Collaborator Author

Not sure if this should merge to rc4 directly. There are a few files that we only want on the orchestrator branch for now.

@Carsonthemonkey Carsonthemonkey requested a review from tab-cmd July 12, 2024 23:33
@tab-cmd tab-cmd changed the base branch from 2.0.0rc4 to session-orchestrator July 15, 2024 16:21
@lawhead
Copy link
Collaborator

lawhead commented Jul 16, 2024

There seem to be a number of previous PRs rolled up into this one that is unrelated to a Task Registry refactor. Did something go wrong with a merge or rebase? Seems like this should be cleaned up so we know what specific changes are introduced here.

@Carsonthemonkey Carsonthemonkey merged commit 0da74ab into session-orchestrator Jul 18, 2024
6 checks passed
@tab-cmd tab-cmd deleted the task_registry_refactor branch November 4, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tab-cmd tab-cmd Awaiting requested review from tab-cmd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Carsonthemonkey @lawhead @tab-cmd