Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bci gui rewrite #337

Merged
merged 82 commits into from
Sep 5, 2024
Merged

Bci gui rewrite #337

merged 82 commits into from
Sep 5, 2024

Conversation

Carsonthemonkey
Copy link
Collaborator

@Carsonthemonkey Carsonthemonkey commented Aug 9, 2024 •
edited
Loading

Overview

Rewrite BCIGui code to be simpler and more maintainable

Ticket

GUI Refactor
Intertask Action

Contributions

  • Rewrite base GUI class
  • Rewrite Experiment registry to extend base gui class
  • Create intertask action with new ui code

Test

  • Manual testing (may want to look into Qt Test in the future for automated GUI testing)

Documentation

  • Inline documentation written for GUI methods

Changelog

  • Changelog updated

@Carsonthemonkey
adds seperate BCIUI file with stylsheet
eedb22f 
This will hopefully replace BCIGui later, but I am keeping it seperate for now as to not break existing uis on this branch
@Carsonthemonkey
update demo experiment layout
cb02d55
@Carsonthemonkey
adjust stylesheet to remove label backgrounds
0b61d25
@Carsonthemonkey
improves gui code to allow for editing fields
c5542e1
@Carsonthemonkey
add basic removeable element
a69241d
@Carsonthemonkey
add dynamic list class for easy ui reactivity
66644ce
@Carsonthemonkey
Add small button component
e250982
@Carsonthemonkey
removes explicit color from small button
b950f9d
@Carsonthemonkey
addds additional buttons to field items
fddf4d4
@Carsonthemonkey
adds basic toggle class
e32eed5
@Carsonthemonkey
changes toggle componenet to be simple connecting function
3365523
@Carsonthemonkey
makes on off callbacks optional in make_toggle
9e82c37
@Carsonthemonkey
add toggle to optional button
32c16d1
@Carsonthemonkey
swaps confusing parameter names
7f4f060
@Carsonthemonkey
loads experiment fields into combobox
5429686
@Carsonthemonkey
adds field buttons
71ffde9
@Carsonthemonkey
refactors gui to be inherited class
cc7ba53 
This improves state handling, as variables and widgets can be stored on the class itself
@Carsonthemonkey
add simple show_alert method
0a4ea36
@Carsonthemonkey
add show_alert method
cfab919
@Carsonthemonkey
adds validation to added fields
502370f
@Carsonthemonkey
remove debug prints
79490cf
@Carsonthemonkey
adds experiment creation to application
c4ce6e0
@Carsonthemonkey Carsonthemonkey changed the base branch from main to 2.0.0rc4 August 9, 2024 19:50
@Carsonthemonkey Carsonthemonkey changed the base branch from 2.0.0rc4 to session-orchestrator August 10, 2024 00:43
tab-cmd
tab-cmd reviewed Aug 15, 2024
View reviewed changes
bcipy/gui/bciui.py Outdated Show resolved Hide resolved
bcipy/gui/bciui.py Show resolved Hide resolved
bcipy/gui/bcipy_stylesheet.css Show resolved Hide resolved
bcipy/gui/bciui.py Outdated Show resolved Hide resolved
bcipy/gui/bciui.py Outdated Show resolved Hide resolved
@Carsonthemonkey Carsonthemonkey marked this pull request as ready for review August 30, 2024 23:06
@Carsonthemonkey Carsonthemonkey merged commit a40d003 into session-orchestrator Sep 5, 2024
6 checks passed
@tab-cmd tab-cmd deleted the bci_gui_rewrite branch November 4, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tab-cmd tab-cmd tab-cmd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Carsonthemonkey @tab-cmd