Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface btn error probability #347

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Surface btn error probability #347

merged 1 commit into from
Sep 16, 2024

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Sep 13, 2024

Overview

This PR surfaces an error probability value used during inquiry preview allowing user change.

Ticket

https://www.pivotaltracker.com/story/show/187994038

Contributions

  • Add a new parameter for button error probability and require it in RSVP Copy Phrase

Test

  • make test-all

Documentation

  • Are documentation updates required? In-line, README, or documentation? N/a

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? TODO

@tab-cmd tab-cmd removed the request for review from danielpklee September 16, 2024 17:52
@tab-cmd tab-cmd merged commit 2d2ba56 into 2.0.0rc4 Sep 16, 2024
6 checks passed
@tab-cmd tab-cmd deleted the surface_btn_error_prob branch September 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawhead lawhead lawhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tab-cmd @lawhead