Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inquiry preview bugfix #348

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Inquiry preview bugfix #348

merged 4 commits into from
Sep 16, 2024

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Sep 13, 2024

Overview

Add a new property to InquiryPreviewProperties; use this to determine if it should be shown during RSVP calibration.

Ticket

https://www.pivotaltracker.com/story/show/188174632

Contributions

  • Add property to InquiryPreviewProperties, update tests.

Test

  • make test-all

Documentation

  • Are documentation updates required? In-line, README, or documentation? Verify the updates you did here. Updated docstrings.

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? TODO.

@tab-cmd tab-cmd requested a review from lawhead September 13, 2024 19:37
@tab-cmd tab-cmd merged commit d9950b1 into 2.0.0rc4 Sep 16, 2024
6 checks passed
@tab-cmd tab-cmd deleted the inquiry_preview_bugfix branch September 16, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawhead lawhead lawhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tab-cmd @lawhead