Inquiry Range Sampler #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inquiries are used
…configured sampler
tab-cmd
approved these changes
Jan 24, 2025
| sampling_strategy=classify( | ||
| sim_args['sampler']), | ||
| task=SimulatorCopyPhraseTask, | ||
| sampler_args=json.loads(sim_args['sampler_args'])) |
There was a problem hiding this comment.
I'd make this a method. We could add some parameter validation or helpful logging to it.
| @@ -43,6 +45,8 @@ For example, | |||
| - `m`: Path to a pickled (.pkl) signal model. One or more models can be provided. | |||
| - `n`: Number of simulation runs | |||
| - `o`: Output directory for all simulation artifacts. | |||
| - `s`: Sampling strategy to use; by default the TargetNonTargetSampler is used. The value provided should be the class name of a Sampler. | |||
| - `sampler_args`: Arguments to pass in to the selected Sampler. Some samplers can be customized with further parameters. These should be structured as a JSON dictionary mapping keys to values. For example: `--sampler_args='{"inquiry_end": 4}'` | |||
There was a problem hiding this comment.
Is this the only parameter that could change in sampling? It may be helpful to have a custom_args= that could be used to modify other parameters in the future, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added a Sampler for filtering the data by inquiry range and series range.
Ticket
https://www.pivotaltracker.com/story/show/188673150
Contributions
Test