Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parameters #99

Merged
merged 5 commits into from
Oct 19, 2020
Merged

Update parameters #99

merged 5 commits into from
Oct 19, 2020

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Oct 18, 2020 •
edited
Loading

Overview

Update to system parameters to reflect names / helptips relevant to the clinical team.

Ticket

https://www.pivotaltracker.com/story/show/174720354

Contributions

  • Uploaded new parameters.json file
  • Reduced collection_window_after_trial_length and len_data_sequence_buffer into trial_length
  • Reduced target_letter_color to target_color
  • Linted using autopep8

Test

  • Unit tests
  • Flake8 Linting
  • Calibration
  • Re-ran offline analysis on older recordings.. Same AUC and artifacts produced

Documentaion

  • Are documentation updates required? no

@tab-cmd
Initial commit (changes provided via clinical team)
3d55c50
@tab-cmd
update parameter load of filters
4603648
@tab-cmd
Merge branch '1.4.3' into update_parameters
6f1a62d
@tab-cmd
Updates to accommodate name changes and adding back things that were …
c4c508d 
…missed

Add back time cross


Update parameter name and add back max_seq_per_trial and max_seq_len


add min_seq_len


reset defaults and add trial complete messages


Use trial length instead of both len_data_sequence_buffer and collection_window_after_trial_length
@tab-cmd
linting
63dbce2
@tab-cmd tab-cmd requested a review from lawhead October 18, 2020 21:05
@tab-cmd tab-cmd merged commit eac3ef6 into 1.4.3 Oct 19, 2020
@tab-cmd tab-cmd deleted the update_parameters branch October 19, 2020 17:57
@tab-cmd tab-cmd mentioned this pull request Jan 20, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawhead lawhead lawhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tab-cmd @lawhead