Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an automatic spell checker #754

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Add an automatic spell checker #754

merged 4 commits into from
Jan 13, 2025

Conversation

tpadioleau
Copy link
Member

@tpadioleau tpadioleau commented Jan 13, 2025 •
edited
Loading

  • exclude "iy" that was fixed by "it"
  • exclude "ND" related to words like "ViewND", that was fixed by "AND"
  • rename "benchs" by "benchmarks"
  • replace "derived" by "differentiated"

@tpadioleau tpadioleau self-assigned this Jan 13, 2025
@tpadioleau tpadioleau marked this pull request as ready for review January 13, 2025 09:26
@tpadioleau
Copy link
Member Author

@EmilyBourne Do you want to review ? I think you might be interested in the tool but you might already know it ?

EmilyBourne
EmilyBourne reviewed Jan 13, 2025
View reviewed changes
.typos.toml Outdated Show resolved Hide resolved
EmilyBourne
EmilyBourne approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@EmilyBourne EmilyBourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for linking me to this. I didn't know about the crate-ci/typos action

@tpadioleau
Copy link
Member Author

tpadioleau commented Jan 13, 2025 •
edited
Loading

Looks good to me. Thanks for linking me to this. I didn't know about the crate-ci/typos action

Cool glad to help! This is the tool used for the Kokkos wiki.

@tpadioleau
Copy link
Member Author

@yasahi-hpc it is easy to use, I also suggest it for Kokkos-fft.

@yasahi-hpc
Copy link
Member

@yasahi-hpc it is easy to use, I also suggest it for Kokkos-fft.

Certainly. I will introduce this soon

@tpadioleau tpadioleau merged commit d6c549c into main Jan 13, 2025
57 checks passed
@tpadioleau tpadioleau deleted the spell-checker branch January 13, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyBourne EmilyBourne EmilyBourne approved these changes

Assignees

@tpadioleau tpadioleau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpadioleau @yasahi-hpc @EmilyBourne