Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Device model commands manager tests #216

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 8, 2022

Description

What's new?

  • Add unit tests on device model commands manager

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 8, 2022 09:54
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #216 (f34a1b1) into main (c3201b7) will increase coverage by 1.60%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #216      +/-   ##
========================================
+ Coverage   6.77%   8.38%   +1.60%     
========================================
  Files         71      71              
  Lines       2361    2361              
========================================
+ Hits         160     198      +38     
+ Misses      2201    2163      -38     
Impacted Files Coverage Δ
...rtal/Server/Managers/DeviceModelCommandsManager.cs 90.47% <0.00%> (+90.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3201b7...f34a1b1. Read the comment docs.

@kbeaugrand kbeaugrand merged commit c863c93 into main Feb 8, 2022
@kbeaugrand kbeaugrand deleted the feature/add_unitary_tests branch February 8, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants