Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce bultin device models (with builtin commands) #259

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Feb 13, 2022

Description

see: #217

What's new?

Add the possibility (by API) to create builtin device models (and commands). These device models are not modifiable via the UI (but still with APIs).
This provide a way to automatically deploy the solution wit builtin features that are extensible.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner February 13, 2022 18:34
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #259 (0891936) into main (21187b1) will increase coverage by 6.86%.
The diff coverage is 81.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   19.89%   26.76%   +6.86%     
==========================================
  Files          77       77              
  Lines        2332     2425      +93     
==========================================
+ Hits          464      649     +185     
+ Misses       1868     1776      -92     
Impacted Files Coverage Δ
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 0.00% <0.00%> (ø)
...lient/Pages/DeviceModels/DeviceModelListPage.razor 0.00% <0.00%> (ø)
.../Server/Controllers/v1.0/DeviceModelsController.cs 78.88% <78.09%> (+78.88%) ⬆️
.../Controllers/v1.0/DeviceModelCommandsController.cs 91.66% <88.88%> (+91.66%) ⬆️
...rtal/Server/Managers/DeviceModelCommandsManager.cs 88.57% <100.00%> (-1.91%) ⬇️
....Portal/Server/Mappers/DeviceModelCommandMapper.cs 100.00% <100.00%> (ø)
...eIoTHub.Portal/Server/Mappers/DeviceModelMapper.cs 100.00% <100.00%> (ø)
...ureIoTHub.Portal/Shared/Models/v1.0/DeviceModel.cs 100.00% <100.00%> (ø)
...ub.Portal/Shared/Models/v1.0/DeviceModelCommand.cs 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21187b1...0891936. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the feature/248_enable_builtin_device_models_apis branch from 0b62485 to 49628b8 Compare February 13, 2022 18:42
@kbeaugrand kbeaugrand changed the title WIP - Add builtin fields on device models and models commands WIP - Introduce bultin device models (with builtin commands) Feb 13, 2022
@kbeaugrand kbeaugrand force-pushed the feature/248_enable_builtin_device_models_apis branch 3 times, most recently from 3e2968b to c7eede9 Compare February 14, 2022 14:52
@kbeaugrand kbeaugrand force-pushed the feature/248_enable_builtin_device_models_apis branch from c7eede9 to 0891936 Compare February 14, 2022 16:11
@kbeaugrand kbeaugrand changed the title WIP - Introduce bultin device models (with builtin commands) Introduce bultin device models (with builtin commands) Feb 14, 2022
@kbeaugrand kbeaugrand merged commit 004a85b into main Feb 14, 2022
@kbeaugrand kbeaugrand deleted the feature/248_enable_builtin_device_models_apis branch February 14, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant