Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #174 activate lora feature with setting #302

Merged
merged 8 commits into from
Feb 24, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Feb 23, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@Sben65 Sben65 requested a review from a team as a code owner February 23, 2022 10:45
@Sben65 Sben65 linked an issue Feb 23, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #302 (68c80cc) into main (647fefe) will increase coverage by 0.59%.
The diff coverage is 45.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   39.70%   40.30%   +0.59%     
==========================================
  Files          93       95       +2     
  Lines        2755     2784      +29     
==========================================
+ Hits         1094     1122      +28     
- Misses       1661     1662       +1     
Impacted Files Coverage Δ
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/CreateDevicePage.razor 0.00% <ø> (ø)
.../AzureIoTHub.Portal/Client/Shared/MainLayout.razor 0.00% <0.00%> (ø)
src/AzureIoTHub.Portal/Client/Shared/NavMenu.razor 0.00% <0.00%> (ø)
...trollers/v1.0/LoRaWAN/LoRaWANCommandsController.cs 79.45% <ø> (ø)
...ers/v1.0/LoRaWAN/LoRaWANConcentratorsController.cs 75.00% <ø> (ø)
...lers/v1.0/LoRaWAN/LoRaWANDeviceModelsController.cs 0.00% <ø> (ø)
src/AzureIoTHub.Portal/Server/Startup.cs 0.00% <0.00%> (ø)
...ntrollers/v1.0/LoRaWAN/LoRaWANDevicesController.cs 100.00% <100.00%> (ø)
...rtal/Server/Controllers/v1.0/SettingsController.cs 100.00% <100.00%> (+100.00%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647fefe...68c80cc. Read the comment docs.

@kbeaugrand kbeaugrand force-pushed the issue_#174_activate_lora_feature_with_setting branch from 3b3e293 to 62f446e Compare February 24, 2022 18:18
@kbeaugrand kbeaugrand force-pushed the issue_#174_activate_lora_feature_with_setting branch from d79baff to 68c80cc Compare February 24, 2022 18:38
@Sben65 Sben65 requested a review from kbeaugrand February 24, 2022 18:55
@kbeaugrand
Copy link
Member

Great

@Sben65 Sben65 merged commit 2e8018c into main Feb 24, 2022
@Sben65 Sben65 deleted the issue_#174_activate_lora_feature_with_setting branch February 24, 2022 19:58
@kbeaugrand kbeaugrand restored the issue_#174_activate_lora_feature_with_setting branch February 24, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Activate LoRa Features by configuration setting
2 participants