Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test to lorawan device model creation page #456

Merged
merged 1 commit into from
Mar 13, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 13, 2022

Description

What's new?

  • Add unit test to lorawan device model creation page

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner March 13, 2022 13:11
@kbeaugrand kbeaugrand force-pushed the fix/disable_custom_properties_in_lora branch from b53a788 to 7ec9a02 Compare March 13, 2022 13:11
@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #456 (7ec9a02) into main (0cab54f) will increase coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   56.73%   57.15%   +0.42%     
==========================================
  Files         111      111              
  Lines        3340     3338       -2     
==========================================
+ Hits         1895     1908      +13     
+ Misses       1445     1430      -15     
Impacted Files Coverage Δ
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 68.34% <ø> (+12.63%) ⬆️
...s/DeviceModels/LoRaWAN/CreateLoraDeviceModel.razor 0.00% <0.00%> (ø)
...rtal/Client/Validators/LoRaDeviceModelValidator.cs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cab54f...7ec9a02. Read the comment docs.

@kbeaugrand kbeaugrand merged commit d029446 into main Mar 13, 2022
@kbeaugrand kbeaugrand deleted the fix/disable_custom_properties_in_lora branch March 13, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant