Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual changes on IoT Edge pages #501

Closed
wants to merge 4 commits into from

Conversation

audserraCGI
Copy link
Contributor

@audserraCGI audserraCGI commented Mar 28, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@audserraCGI audserraCGI requested a review from a team as a code owner March 28, 2022 14:13
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #501 (af26bf6) into main (3c207d7) will decrease coverage by 0.47%.
The diff coverage is 39.13%.

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   60.75%   60.27%   -0.48%     
==========================================
  Files         114      114              
  Lines        3710     3736      +26     
==========================================
- Hits         2254     2252       -2     
- Misses       1456     1484      +28     
Impacted Files Coverage Δ
...s/DeviceModels/LoRaWAN/CreateLoraDeviceModel.razor 0.00% <0.00%> (ø)
...ges/DeviceModels/LoRaWAN/EditLoraDeviceModel.razor 0.00% <0.00%> (ø)
...Portal/Client/Pages/Devices/CreateDevicePage.razor 0.00% <ø> (ø)
...nt/Pages/Edge_Devices/CreateEdgeDeviceDialog.razor 0.00% <0.00%> (ø)
...ient/Pages/Edge_Devices/EdgeDeviceDetailPage.razor 0.00% <0.00%> (ø)
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 56.83% <54.54%> (-5.87%) ⬇️
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 55.39% <91.66%> (-12.95%) ⬇️
...b.Portal/Client/Validators/DeviceModelValidator.cs 100.00% <100.00%> (ø)
...ortal/Client/Validators/DevicePropertyValidator.cs 100.00% <100.00%> (+5.55%) ⬆️
...rtal/Client/Validators/LoRaDeviceModelValidator.cs 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c207d7...af26bf6. Read the comment docs.

@kbeaugrand
Copy link
Member

Duplicates #504

@kbeaugrand kbeaugrand closed this Mar 28, 2022
@kbeaugrand kbeaugrand deleted the 491_visual_changes_on_iot_edge_pages branch March 28, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Visual changes on IoT Edge pages Task: Move "Connect" button under the image
2 participants