Update Onyx port, update unit test output #617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Update Onyx port after significant Onyx system update, Update unit test output.
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
Testing on Onyx passes, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#85531cf8f8ae93f628344df6ecfa4be12e9629d8 although answers changes for Onyx due to new compilers. The failed tests are associated with the sumchk unit test. This seems to be an issue with the mpich implementation on Onyx with real4 and real16. The other test that fails is an alt04 test. This fails on a zap_snow_temperature error with only the Cray compiler. This may need some additional investigation in the future.
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on Icepack or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
Please provide any additional information or relevant details below:
Update unit test output and scripts to differentiate completed runs and successful testing better
sumchk is not passing on Onyx due to issues in the global reduction at real16 and real4. This seems to be a software bug in mpich and a report has been issued to Onyx admins.
minor update to documentation to describe how the unit test scripts validate the unit test runs.