Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-8626: Add supporting terraform for new BCDA lambda #162

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

carlpartridge
Copy link
Contributor

@carlpartridge carlpartridge commented Jan 15, 2025

🎫 Ticket

https://jira.cms.gov/browse/BCDA-8626

🛠 Changes

Add supporting terraform for new BCDA lambda (admin task Deny ACOs), mostly copy pasted from similar lambdas.

ℹ️ Context

New BCDA lambda. Part of the move from jenkins.

🧪 Validation

Local terraform lint

@carlpartridge carlpartridge marked this pull request as ready for review January 15, 2025 15:56
@carlpartridge carlpartridge requested a review from a team as a code owner January 15, 2025 15:56
@@ -0,0 +1,41 @@
locals {
Copy link
Contributor Author

@carlpartridge carlpartridge Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not entirely sure if I correctly cherry picked everything over from the other lambda services. The lambda needs access to the BCDA DB but gets that from a parameter store DB URL. It also contacts CMS slack via another parameter store slack webhook url.

@carlpartridge carlpartridge changed the title BCDA-8626: Copy paste, update relevant files BCDA-8626: Add supporting terraform for new BCDA lambda Jan 16, 2025
Copy link
Contributor

@gfreeman-navapbc gfreeman-navapbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlpartridge carlpartridge merged commit 2479bed into main Jan 17, 2025
11 checks passed
@carlpartridge carlpartridge deleted the carl/BCDA-8626-add-admin-aco-deny-lambda-tf branch January 17, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants