BCDA-8360 add waf sync lambda #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpartridge
changed the title
carlpartridge
force-pushed
the
carl/BCDA-8360-add-waf-sync-lambda
branch
from
0981f4e to
6f5068b
Compare
laurenkrugen-navapbc
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Approving, with the steps I took to validate:
- review lambda invocation to ensure that it's running with no errors (it is)
- review logs for success messages (they are present)
The only thing that we should do before we cutover is put some test data in our lower env to make sure it works properly. I looked in the dev WAF, and there are no IP addresses. Maybe we can coordinate with @gfreeman-navapbc on some safe-for-use IPs that we can dump in there in the interim?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8360
🛠 Changes
Add WAF auto sync lambda
ℹ️ Context
We have recently switched over to WAF to control our allowlist of IP addresses. This lambda should sync our app DB with the source of truth on IP addresses to our WAF.
🧪 Validation
Local tests and linting passing.