-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLUEBUTTON-1644: Adding Pipfiles #187
Conversation
They're useful for running Ansible, etc. locally, and I've had them laying around locally forever. Eventually, it'd be good to try and consolidate them and also remove the older requirements.txt files that are still there, but... baby steps. (Note that this has nothing to do with the referenced JIRA ticket, except that I was working on it when I finally decided to clean this up.) BLUEBUTTON-1644
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some question as to if the pipfile
idea is still active, from their docs it isn't stable yet and there hasn't been work on the spec itself for a couple years. Pipenv is a great tool for local dev but I'd suggest avoiding it in production.
In order to lock down requirements pip allows a require hash mode that works with a requirements.txt
file. To lock down even further installing from a local copy is also an option.
To make this easier I believe both pipenv and pip-tools provide paths to help manage the requirements.txt files with hashes.
This makes me a very sad 🐼. The user experience with If you were going to ask the "Python community at large" what's going on with |
Drat: see pypa/pipenv#3742 and linked issues. Sounds like it might get resurrected, but is definitely currently dead. Moving away from it, the main thing I'll miss is how easy it makes it to use venvs: just slap a prefix on the command! @whytheplatypus do you know of any solid alternatives for that? |
In terms of usability the pip-tools suite makes managing requirements.txt files more .... manageable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pipfile is alive. pypa/pipenv#3369
LGTM.
Did pipfile die and get revived in the time this PR was open? ☠️ |
They're useful for running Ansible, etc. locally, and I've had them laying around locally forever. Eventually, it'd be good to try and consolidate them and also remove the older requirements.txt files that are still there, but... baby steps.
(Note that this has nothing to do with the referenced JIRA ticket, except that I was working on it when I finally decided to clean this up.)
https://jira.cms.gov/browse/BLUEBUTTON-1644