-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFD-3818: IDR-based mapping of Patient resource using FHIR Mapping Language #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-dzeda
commented
Feb 5, 2025
alex-dzeda
commented
Feb 5, 2025
aschey-forpeople
requested changes
Feb 5, 2025
apps/bfd-model/bfd-model-idr/dictionary-support-yamls/patient.yaml
Outdated
Show resolved
Hide resolved
mjburling
reviewed
Feb 6, 2025
Co-authored-by: Michael J Burling <[email protected]>
aschey-forpeople
previously approved these changes
Feb 6, 2025
aschey-forpeople
approved these changes
Feb 6, 2025
mjburling
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3818
What Does This PR Do?
This PR builds off BFD-3817 and updates the StructureDefinitions to allow for a complete mapping of the Patient resource using IDR columns. Of note, the race/ethnicity conceptmap structure is messy; the FHIR Validator does not want to play nice on the ConceptMap translation, and this is a point for future improvement (ideally, we could consolidate this significantly by passing the source value in and getting a complete coding, but the use of extensions complicates this due to the validator assuming the slicing.)
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Really, the biggest concerns may revolve around syntax and directory structure. If there's a foreseen problem, please speak up!
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe
) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
Following the instructions in the README allows one to
Example Output Resource:
{ "resourceType" : "Patient", "id" : "123456789", "meta" : { "lastUpdated" : "2020-01-07T03:02:28.000000Z", "profile" : ["http://hl7.org/fhir/us/carin-bb/StructureDefinition/C4BB-Patient|2.0.0", "http://hl7.org/fhir/us/core/StructureDefinition/us-core-patient|3.1.1"] }, "extension" : [{ "extension" : [{ "url" : "ombCategory", "valueCoding" : { "system" : "urn:oid:2.16.840.1.113883.6.238", "code" : "2135-2", "display" : "Hispanic or Latino" } }, { "url" : "text", "valueString" : "Hispanic or Latino" }], "url" : "http://hl7.org/fhir/us/core/StructureDefinition/us-core-ethnicity" }], "identifier" : [{ "type" : { "coding" : [{ "system" : "http://terminology.hl7.org/CodeSystem/v2-0203", "code" : "MB" }] }, "system" : "http://hl7.org/fhir/sid/us-mbi", "value" : "AAA1AA0AA11", "period" : { "start" : "2017-05-11", "end" : "2017-07-01" } }, { "type" : { "coding" : [{ "system" : "http://terminology.hl7.org/CodeSystem/v2-0203", "code" : "MB" }] }, "system" : "http://hl7.org/fhir/sid/us-mbi", "value" : "ABB2BB0BB22", "period" : { "start" : "2017-07-02" } }], "name" : [{ "family" : "Sheep", "given" : ["Frankie", "Le Petit Prince"] }], "telecom" : [{ "system" : "phone", "value" : "1-800-MEDICARE", "use" : "home" }], "gender" : "female", "birthDate" : "1995-03-11", "deceasedDateTime" : "2024-03-11", "address" : [{ "line" : ["600 John Kimbrough Blvd", "TEST for line 2"], "city" : "College Station", "state" : "TX", "postalCode" : "77843" }], "link" : [{ "other" : { "reference" : "Patient/234567891", "display" : "234567891" }, "type" : "replaces" }] }