-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brandon/bb2 3360 smart on fhir #1272
Conversation
… to match between versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, let's just make sure Alex signs off on this too before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bwang-icf Alex pointed out that the url here is actually incorrect, it should be well-known
not wellknown
. Can you get that fixed as part of this PR?
Made new comments that should be addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes to the output + path.
JIRA Ticket:
BB2-3360
What Does This PR Do?
Removing some unnecessary fields for smart config endpoint
What Should Reviewers Watch For?
Any other unnecessary fields or improper response
Validation
Ran a get request for localhost:8000/v1/fhir/.wellknown/smart-configuration and v2 in postman
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)