Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brandon/bb2 3360 smart on fhir #1272

Merged
merged 17 commits into from
Dec 12, 2024
Merged

Conversation

bwang-icf
Copy link
Contributor

JIRA Ticket:
BB2-3360

What Does This PR Do?

Removing some unnecessary fields for smart config endpoint

What Should Reviewers Watch For?

Any other unnecessary fields or improper response

Validation

Ran a get request for localhost:8000/v1/fhir/.wellknown/smart-configuration and v2 in postman

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • [ X] No migrations

@jimmyfagan jimmyfagan self-requested a review December 9, 2024 18:03
jimmyfagan
jimmyfagan previously approved these changes Dec 9, 2024
Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's just make sure Alex signs off on this too before merging.

@jimmyfagan jimmyfagan self-requested a review December 12, 2024 16:46
Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwang-icf Alex pointed out that the url here is actually incorrect, it should be well-known not wellknown. Can you get that fixed as part of this PR?

@jimmyfagan jimmyfagan self-requested a review December 12, 2024 16:47
@jimmyfagan jimmyfagan dismissed their stale review December 12, 2024 16:47

Made new comments that should be addressed

Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@alex-dzeda alex-dzeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes to the output + path.

@bwang-icf bwang-icf merged commit 4300f92 into master Dec 12, 2024
6 checks passed
@bwang-icf bwang-icf deleted the brandon/BB2-3360-smart-on-fhir branch December 12, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants