Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-3579: Update Django to 4.2.17 #1273

Merged
merged 4 commits into from
Dec 13, 2024
Merged

BB2-3579: Update Django to 4.2.17 #1273

merged 4 commits into from
Dec 13, 2024

Conversation

sb-benohe
Copy link
Contributor

@sb-benohe sb-benohe commented Dec 11, 2024

JIRA Ticket:
BB2-3579

What Does This PR Do?

Updates Django to 4.2.17

What Should Reviewers Watch For?

that this PR properly builds and pasts tests

If you're reviewing this PR, please check for these things in particular:

the minor version bump of django does not break any key functionality.

Validation

standard tests

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@sb-benohe sb-benohe added the dependencies Pull requests that update a dependency file label Dec 11, 2024
@sb-benohe sb-benohe self-assigned this Dec 11, 2024
Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question: are we good to delete the old whl files for the older versions of django and crypography?

@sb-benohe
Copy link
Contributor Author

Looks good, just one question: are we good to delete the old whl files for the older versions of django and crypography?

yes we are good to remove them, I'll do that with this PR

Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and thanks for cleaning up all those other dependencies.

Copy link
Contributor

@noor1027 noor1027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

@sb-benohe sb-benohe enabled auto-merge (squash) December 13, 2024 14:27
@sb-benohe sb-benohe merged commit 89e9075 into master Dec 13, 2024
6 checks passed
@sb-benohe sb-benohe deleted the bb2-3579 branch December 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants