-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB2-3579: Update Django to 4.2.17 #1273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question: are we good to delete the old whl files for the older versions of django and crypography?
yes we are good to remove them, I'll do that with this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and thanks for cleaning up all those other dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me
JIRA Ticket:
BB2-3579
What Does This PR Do?
Updates Django to 4.2.17
What Should Reviewers Watch For?
that this PR properly builds and pasts tests
If you're reviewing this PR, please check for these things in particular:
the minor version bump of django does not break any key functionality.
Validation
standard tests
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)