Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more specific message for invalid state code in header #16

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

mint-thompson
Copy link
Collaborator

When validating the header columns, assume that a column name that contains one pipe and matches "license_number" before the pipe is probably the license number column. This means that the part of the name after the pipe should be a valid state code. If not, show an error message indicating that the state code is not valid.

When validating the header columns, assume that a column name that
contains one pipe and matches "license_number" before the pipe is
probably the license number column. This means that the part of the name
after the pipe should be a valid state code. If not, show an error
message indicating that the state code is not valid.
Message includes the URL for the state code table.
@shaselton-usds shaselton-usds self-requested a review February 29, 2024 17:31
Copy link
Collaborator

@shaselton-usds shaselton-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mint-thompson mint-thompson merged commit 1e999ca into main Feb 29, 2024
4 checks passed
@mint-thompson mint-thompson deleted the license-number-message branch February 29, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants