Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow warnings in header and columns #17

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

mint-thompson
Copy link
Collaborator

If errors occur during validation of the header and columns, parsing stops. Parsing continues as long as no errors occur, even if warnings occur.

Note that the current implementation does not have any associated tests. The currently implemented CSV validators do not have any way of creating a warning when validating the header and columns. Testing this will require finding and using a function mock package, which will require additional research.

If errors occur during validation of the header and columns, parsing
stops. Parsing continues as long as no errors occur, even if warnings
occur.

Note that the current implementation does not have any associated tests.
The currently implemented CSV validators do not have any way of creating
a warning when validating the header and columns. Testing this will
require finding and using a function mock package, which will require
additional research.
@shaselton-usds shaselton-usds self-requested a review February 29, 2024 17:29
Copy link
Collaborator

@shaselton-usds shaselton-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that it was mentioned that further research would be needed, but I'd be interested in how the collection of warnings when evaluating the values would work.

@mint-thompson mint-thompson merged commit fbaa5ee into main Feb 29, 2024
4 checks passed
@mint-thompson mint-thompson deleted the allow-warning-in-headers branch February 29, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants