Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202100961 송승경] 1주차 미션을 제출합니다. #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thdtmdrud
Copy link

No description provided.

Copy link
Member

@jungbug jungbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승경님!

1주차 미션하시느라 수고 많으셨습니다!!

html뿐만 아니라 css까지 전부다 끝내셨네요..!

우선 html 부분에서는 딱히 리뷰할게 없는거 같아요!
다만 css 부분에서는 한 css파일 안에 전부다 쓰셨는데

추후에 파일들이 많아지면 유지보수가 힘들어질수도 있어서 html 파일마다 분리해서 작성하는걸 추천드릴게요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants