Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Output qualities in SAM output #756

Closed
A-N-Other opened this issue Feb 28, 2022 · 3 comments
Closed

[Feature Request] Output qualities in SAM output #756

A-N-Other opened this issue Feb 28, 2022 · 3 comments

Comments

@A-N-Other
Copy link
Contributor

A-N-Other commented Feb 28, 2022

I understand that salmon does not use read quality scores when performing alignment/quantitation but, as it stands, running with --writeMappings it also doesn't output the qualities in its SAM-format output.

That may not impact most downstream applications of the data but it does limit some. I'd be particularly interested in using reads that have been aligned and assigned to transcripts with an EM algorithm to investigate RNA editing. The most advanced methods of doing this integrate the quality of base calls from the sequencer into the models and, as such, cannot currently run on the data output.

Although it may save a few CPU cycles in not reading and outputting the qualities - I can understand the choice when running with default settings - when running with --writeMappings that nominal difference in speed needs to be weighed up against downstream utility. Could this be looked into?

Cheers! George

@rob-p
Copy link
Collaborator

rob-p commented Mar 16, 2022

Hi George,

This will require some upstream changes to the SAM writing code, but I don't think it should be too hard. We could add this to the roadmap. I'll tag this as an enhancement.

--Rob

@A-N-Other
Copy link
Contributor Author

Thanks for that. It would be so handy to have this! As it stands, I've written a Python script to intercept the collated output and add back in the qualities from the FASTQs but it's not exactly a speedy process ...

Thanks for your help and for all the work with Salmon!

rob-p pushed a commit that referenced this issue Jun 21, 2022
This addresses the feature request made in #756.
@rob-p
Copy link
Collaborator

rob-p commented Jun 23, 2022

Released in v1.9.0 🎉 ! Let us know if you have any questions about or trouble with the feature.

@rob-p rob-p closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants