Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

counter artificial increase in barcode length #817

Merged
merged 1 commit into from
Feb 23, 2023
Merged

counter artificial increase in barcode length #817

merged 1 commit into from
Feb 23, 2023

Conversation

Gaura
Copy link
Collaborator

@Gaura Gaura commented Dec 9, 2022

Subtract 2 to counter artificial increase in barcode length. Read1 length of 33 or 34 would result in error while being valid lengths.

@Gaura
counter artificial increase in barcode length
f2238f0 
Subtract 2 to counter artificial increase in barcode length. Read1 length of 33 or 34 would result in error while being valid lengths.
@Gaura Gaura requested a review from rob-p December 9, 2022 20:03
@Gaura
Copy link
Collaborator Author

Gaura commented Dec 9, 2022

fixes #813

@rob-p rob-p changed the base branch from master to develop December 9, 2022 20:06
@Gaura Gaura mentioned this pull request Dec 9, 2022
Closed
@Gaura Gaura linked an issue Dec 10, 2022 that may be closed by this pull request
Can't find left Boundary #813
Closed
rob-p
rob-p approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@rob-p rob-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Gaura, I'm going to approve and merge this now because I need to cut a new release. However, we should definitely loop back around and see if we can solve this more generally for all variable length barcode protocols.

@rob-p rob-p merged commit 42c59ac into develop Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob-p rob-p rob-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't find left Boundary
2 participants
@Gaura @rob-p