Skip to content

Commit

Permalink
Remove SF_ARC_FIX from G5 (Cubic B-spline)
Browse files Browse the repository at this point in the history
Remove SF_ARC_FIX from G5 (Cubic B-spline).
SF_ARC_FIX is a fix for G2/G3 (arcs) where Skeinforge always produced relative instead of absolute coordinates for the endpoint of an arc.
It's very unlikely this is also a problem with Cubic B-splines. More likely is copying from the G2/G3 code.
  • Loading branch information
AnHardt authored and CONSULitAS committed Aug 18, 2016
1 parent da52ac9 commit 7ec52e6
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions Marlin/Marlin_main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
* G2 - CW ARC
* G3 - CCW ARC
* G4 - Dwell S<seconds> or P<milliseconds>
* G5 - Cubic B-spline with
* G5 - Cubic B-spline with XYZE destination and IJPQ offsets
* G10 - retract filament according to settings of M207
* G11 - retract recover filament according to settings of M208
* G28 - Home one or more axes
Expand Down Expand Up @@ -2548,14 +2548,7 @@ inline void gcode_G4() {
inline void gcode_G5() {
if (IsRunning()) {

#ifdef SF_ARC_FIX
bool relative_mode_backup = relative_mode;
relative_mode = true;
#endif
gcode_get_destination();
#ifdef SF_ARC_FIX
relative_mode = relative_mode_backup;
#endif

float offset[] = {
code_seen('I') ? code_value() : 0.0,
Expand Down

0 comments on commit 7ec52e6

Please sign in to comment.