Remove buffer from longitude slicer #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #121 |
This needs to be in the first PR message so that the issue is linked with the PR. You can edit the first msg and add this. |
navidcy
reviewed
Mar 26, 2024
navidcy
reviewed
Mar 26, 2024
navidcy
reviewed
Mar 26, 2024
navidcy
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #121 I revised this part of the code and I don't think the buffer here is necessary. I think the longitude slicer should just be handed the slice with a buffer included (as with the regular slicing with .sel) rather than having an inbuilt buffer
As it was being used there was already a buffer in the slice being passed to longitude slicer anyway so buffer was redundant!