ci: optional tests fail in CI #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-q
force-pushed
the
doug/fail-skipped-tests-in-ci
branch
from
5e6f699 to
b96cf26
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 60 60
Lines 6130 6130
=======================================
Hits 5612 5612
Misses 518 518 ☔ View full report in Codecov by Sentry. |
acl-cqc
reviewed
Sep 18, 2024
| pytest.fail("Validator not installed") | ||
| else: | ||
| pytest.skip( | ||
| "Skipping validation: Run `cargo build` to install the validator" |
croyzor
reviewed
Sep 30, 2024
|
|
||
| except ImportError as e: | ||
| if IN_CI: | ||
| pytest.fail(f"run_int_fn failed in CI: {e}") |
There was a problem hiding this comment.
This should be something like "execute_llvm not installed in CI"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.