Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadConstant nodes can't have OrderEdges #1167

Closed
doug-q opened this issue Jun 6, 2024 · 1 comment · Fixed by #1293
Closed

LoadConstant nodes can't have OrderEdges #1167

doug-q opened this issue Jun 6, 2024 · 1 comment · Fixed by #1293
Assignees
Labels
bug Something isn't working

Comments

@doug-q
Copy link
Collaborator

doug-q commented Jun 6, 2024

At present Nodes are only allowed one kind of other_port_kind. This seems like an artificial restriction, which good taste demands should be lifted, but "LoadConstant nodes can't have OrderEdges" does seem like a limitation.

In my mind LoadConstant is an operation with side effects. Memory side effects being obvious, but also LoadConstant of a Value::Function can be read as compiling that value. As such, users should be able to impose an order on two LoadConstant operations to control the order of their side effects.

Weaker arguments for nodes to have multiple other_port_kinds:

  • Case nodes in a conditional are interpreted with respect to their index into their parent. This is ugly, one could instead demand, or allow, that they have order edges which induce a total order, and use that total order to assign them an index.
  • DataFlowBlocks could get indices in the same was as Case above.

edges spec issue: #848

@doug-q doug-q changed the title LoadConstant nodes can't have OrderEdges LoadConstant nodes can't have OrderEdges Jun 6, 2024
@ss2165 ss2165 added the bug Something isn't working label Jun 19, 2024
@ss2165 ss2165 self-assigned this Jul 3, 2024
@ss2165
Copy link
Member

ss2165 commented Jul 12, 2024

Not an issue, demonstrated in #1293

@ss2165 ss2165 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants