Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cases in different order breaks builder #1596

Closed
mark-koch opened this issue Oct 18, 2024 · 0 comments · Fixed by #1599
Closed

Adding cases in different order breaks builder #1596

mark-koch opened this issue Oct 18, 2024 · 0 comments · Fixed by #1599
Assignees
@ss2165
Labels
bug Something isn't working python Pull requests that update Python code

Comments

@mark-koch
Copy link
Contributor

This works,

cond = Conditional(tys.Either([tys.USize()], [tys.Unit]), [])
with cond.add_case(0) as case:
    case.set_outputs()
with cond.add_case(1) as case:
    case.set_outputs()

but this fails validation:

cond = Conditional(tys.Either([tys.USize()], [tys.Unit]), [])
with cond.add_case(1) as case:
    case.set_outputs()
with cond.add_case(0) as case:
    case.set_outputs()
@mark-koch mark-koch added bug Something isn't working python Pull requests that update Python code labels Oct 18, 2024
@mark-koch mark-koch mentioned this issue Oct 18, 2024
Merged
@ss2165 ss2165 self-assigned this Oct 18, 2024
ss2165 added a commit that referenced this issue Oct 18, 2024
@ss2165
fix(py): allow conditional cases to be defined out of order
249a6c0 
Closes #1596

Was tempted to just change the type of `cases` since who would be using it anyway but I've tried to be good and deprecate instead
@ss2165 ss2165 mentioned this issue Oct 18, 2024
Merged
ss2165 added a commit that referenced this issue Oct 18, 2024
@ss2165
fix(py): allow conditional cases to be defined out of order
794034b 
Closes #1596

Was tempted to just change the type of `cases` since who would be using it anyway but I've tried to be good and deprecate instead
ss2165 added a commit that referenced this issue Oct 18, 2024
@ss2165
fix(py): allow conditional cases to be defined out of order
a15a89e 
Closes #1596

Was tempted to just change the type of `cases` since who would be using it anyway but I've tried to be good and deprecate instead
github-merge-queue bot pushed a commit that referenced this issue Oct 23, 2024
@ss2165
fix(py): allow conditional cases to be defined out of order (#1599)
583d21d 
Closes #1596

Was tempted to just change the type of `cases` since who would be using
it anyway but I've tried to be good and deprecate instead
ss2165 added a commit that referenced this issue Nov 22, 2024
@ss2165
fix(py): allow conditional cases to be defined out of order (#1599)
43373c9 
Closes #1596

Was tempted to just change the type of `cases` since who would be using
it anyway but I've tried to be good and deprecate instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(py): allow conditional cases to be defined out of order CQCL/hugr
2 participants
@ss2165 @mark-koch