Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Resolve OpaqueOps and CustomType extensions #1735

Merged
merged 8 commits into from
Dec 3, 2024

visibility and nits

88d8b25
Select commit
Loading
Failed to load commit list.
Merged

feat!: Resolve OpaqueOps and CustomType extensions #1735

visibility and nits
88d8b25
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 3, 2024 in 0s

86.21% (-0.11%) compared to 4586db3

View this Pull Request on Codecov

86.21% (-0.11%) compared to 4586db3

Details

Codecov Report

Attention: Patch coverage is 84.14443% with 101 lines in your changes missing coverage. Please review.

Project coverage is 86.21%. Comparing base (4586db3) to head (88d8b25).

Files with missing lines Patch % Lines
hugr-core/src/extension/resolution/types.rs 73.21% 2 Missing and 28 partials ⚠️
hugr-core/src/extension/resolution/ops.rs 58.92% 21 Missing and 2 partials ⚠️
hugr-core/src/hugr/validate.rs 20.83% 13 Missing and 6 partials ⚠️
hugr-core/src/extension.rs 23.52% 13 Missing ⚠️
hugr-passes/src/const_fold/test.rs 98.13% 4 Missing ⚠️
hugr-core/src/ops/custom.rs 89.28% 3 Missing ⚠️
hugr-core/src/hugr/serialize/test.rs 83.33% 0 Missing and 2 partials ⚠️
hugr-core/src/hugr/validate/test.rs 92.00% 2 Missing ⚠️
hugr-core/src/builder.rs 0.00% 0 Missing and 1 partial ⚠️
hugr-core/src/builder/dataflow.rs 83.33% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1735      +/-   ##
==========================================
- Coverage   86.32%   86.21%   -0.11%     
==========================================
  Files         167      170       +3     
  Lines       30639    30730      +91     
  Branches    27551    27642      +91     
==========================================
+ Hits        26449    26494      +45     
- Misses       2605     2626      +21     
- Partials     1585     1610      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov