feat: Automatically add the custom op's extension to its 'runtime_reqs' set #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1787 +/- ##
=======================================
Coverage 86.52% 86.52%
=======================================
Files 188 188
Lines 34203 34205 +2
Branches 31076 31076
=======================================
+ Hits 29595 29597 +2
Misses 2923 2923
Partials 1685 1685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ss2165
approved these changes
Dec 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.10.0](hugr-py-v0.9.0...hugr-py-v0.10.0) (2024-12-16) ### ⚠ BREAKING CHANGES * Removed the extension registry argument from `validate` calls. Removed the extension registry argument from operation instantiation methods. Removed most extension-specific test registries. Use `EMPTY_REG`, `PRELUDE_REGISTRY`, or `STD_REG` instead. * `extension_reqs` field in FunctionType and Extension renamed to `runtime_reqs` * Array type and operations have been moved out of `prelude` and into a new `collections.array` extension. (py) `list_type` method replaced with `List` class. Removed `Array` type variant from the serialization format. * `collections` extension renamed to `collections.list` * The `LoadFunction::signature` field is removed. Replace uses with `DataflowOpTrait::signature()`. * Array `scan` and `repeat` ops get an additional type parameter specifying the extension requirements of their input functions. Furthermore, `repeat` is no longer part of `ArrayOpDef` but is instead specified via a new `ArrayScan` struct. ### Features * Add `LoadNat` operation to enable loading generic `BoundedNat`s into runtime values ([#1763](#1763)) ([6f035d6](6f035d6)), closes [#1629](#1629) * Add array `repeat` and `scan` ops ([#1633](#1633)) ([649589c](649589c)), closes [#1627](#1627) * Automatically add the custom op's extension to its 'runtime_reqs' set ([#1787](#1787)) ([3ef5bd9](3ef5bd9)) * Don't require explicit extension registers for validation ([#1784](#1784)) ([b517dc3](b517dc3)) * Make array repeat and scan ops generic over extension reqs ([#1716](#1716)) ([4c1c6ee](4c1c6ee)) * Move arrays from prelude into new extension ([#1770](#1770)) ([187ea8f](187ea8f)) * Rename `collections` extension to `collections.list` ([#1764](#1764)) ([eef239f](eef239f)) * rename `extension_reqs` to `runtime_reqs` ([#1776](#1776)) ([5f5bce4](5f5bce4)) ### Bug Fixes * hugr-py not adding extension-reqs on custom ops ([#1759](#1759)) ([97ba7f4](97ba7f4)) * **py:** allow conditional cases to be defined out of order ([#1599](#1599)) ([583d21d](583d21d)) * Replace `LoadFunction::signature` with `LoadFunction::instantiation` ([#1756](#1756)) ([5b50d1d](5b50d1d)) * Resolve types in `Value`s and custom consts ([#1779](#1779)) ([080eaae](080eaae)) * Update number of ports for PartialOps, and sanitize orderd edges ([#1635](#1635)) ([81a1385](81a1385)), closes [#1625](#1625) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Seyon Sivarajah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignores custom operations that are missing their own extension as a runtime req when validating.
drive-by: Update doc that still refered to
extension_requirements