Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Port with OutgoingPort/IncomingPort where possible #220

Closed
aborgna-q opened this issue Nov 7, 2023 · 0 comments · Fixed by #296
Closed

Replace Port with OutgoingPort/IncomingPort where possible #220

aborgna-q opened this issue Nov 7, 2023 · 0 comments · Fixed by #296
Assignees
@aborgna-q
Labels
enhancement New feature or request

Comments

@aborgna-q
Copy link
Collaborator

A partial update was done in #219.

The two big targets of this issue are:

  • Units iterator and filters. These return a generic Port, where it would be lot safer to have directed variants.

  • portmatching. Here the move should be easy, except for the fact that the directed port variants do not currently implement Serialize, so they cannot be stored in the pattern structs.
@aborgna-q aborgna-q added enhancement New feature or request P-low labels Nov 7, 2023
@aborgna-q aborgna-q self-assigned this Nov 7, 2023
@aborgna-q aborgna-q mentioned this issue Nov 7, 2023
Merged
This was referenced Feb 27, 2024
Merged
Merged
github-merge-queue bot pushed a commit to CQCL/hugr that referenced this issue Feb 28, 2024
@aborgna-q
feat: Make all core types serializable (#850)
ff5f117 
Implements serialization on some core types that where missing it
(Incoming/Outgoing ports, Wires, ...)

Required for CQCL/tket2#220
github-merge-queue bot pushed a commit that referenced this issue Mar 1, 2024
@aborgna-q
feat: Use IncomingPort and OutgoingPort instead of Port where p…
93f83ac 
…ossible. (#296)

Mostly a refactor. The `Units` struct required some API changes so the
iterator can return the kind of port matching its direction.

Closes #220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Use IncomingPort and OutgoingPort instead of Port where possible. CQCL/tket2
1 participant
@aborgna-q