feat: Configure benchmarking, add hashing benches #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aborgna-q
commented
Aug 31, 2023
aborgna-q
commented
- Correctly configures benchmarking with criterion.
- Adds a layer-of-cnots circuit generator to bench with.
- Adds benches for the hashing code in feat: Circuit hashing and some tests #65
lmondada
approved these changes
Sep 1, 2023
benches/benchmarks/generators.rs
Outdated
Comment on lines
10
to
26
| pub fn build_simple_circuit( | ||
| num_qubits: usize, | ||
| f: impl FnOnce(&mut CircuitBuilder<DFGBuilder<Hugr>>) -> Result<(), BuildError>, | ||
| ) -> Result<Hugr, BuildError> { | ||
| let qb_row = vec![QB_T; num_qubits]; | ||
| let mut h = DFGBuilder::new(FunctionType::new(qb_row.clone(), qb_row))?; | ||
|
|
||
| let qbs = h.input_wires(); | ||
|
|
||
| let mut circ = h.as_circuit(qbs.into_iter().collect()); | ||
|
|
||
| f(&mut circ)?; | ||
|
|
||
| let qbs = circ.finish(); | ||
| h.finish_hugr_with_outputs(qbs) | ||
| } |
There was a problem hiding this comment.
This was moved to src/utils.rs, which I think is a good place for it.
There was a problem hiding this comment.
Yes, but it's pub(crate), so we cannot use it in the benchmarks.
I guess we could make it public. What do you think?
aborgna-q
force-pushed
the
feat/hashing-benchmarks
branch
2 times, most recently
from
00a10de to
a8f6ef5
Compare
|
Updated the hugr dependency to include CQCL/hugr#485 |
ss2165
pushed a commit
that referenced
this pull request
Sep 4, 2023
- Correctly configures benchmarking with criterion. - Adds a layer-of-cnots circuit generator to bench with. - Adds benches for the hashing code in #65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.