chore: update to pyo3 0.23.2 and tket-json-rs 0.7.1 #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
requested review from
doug-q and
johnchildren
and removed request for
doug-q
johnchildren
approved these changes
Nov 29, 2024
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #709 +/- ##
==========================================
- Coverage 82.85% 82.79% -0.07%
==========================================
Files 62 62
Lines 7140 7115 -25
Branches 6887 6862 -25
==========================================
- Hits 5916 5891 -25
Misses 861 861
Partials 363 363
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ss2165
commented
Nov 29, 2024
| @@ -77,21 +78,24 @@ fn validate_serial_circ(circ: &SerialCircuit) { | |||
| for command in &circ.commands { | |||
| for arg in &command.args { | |||
| assert!( | |||
| circ.qubits.contains(arg) || circ.bits.contains(arg), | |||
| circ.qubits.contains(®ister::Qubit::from(arg.clone())) | |||
There was a problem hiding this comment.
added clones but figure it is ok in tests
cqc-alec
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.