Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: symbolic parameters + more T2ops #90

Merged
merged 4 commits into from
Sep 6, 2023
Merged

feat: symbolic parameters + more T2ops #90

merged 4 commits into from
Sep 6, 2023

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Sep 5, 2023

temporary - when we have a better idea of angle/rotation types can use a HUGR input for symbols instead

Closes #82

@ss2165 ss2165 requested a review from aborgna-q September 5, 2023 15:12
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use some more docs, but LGTM as a temporary thing.

src/ops.rs Outdated
const SYM_OP_ID: SmolStr = SmolStr::new_inline("symbolic_float");

/// Initialize a new custom symbolic expression constant op from a string.
pub fn symolic_constant_op(s: &str) -> OpType {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symbolic

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@ss2165 ss2165 merged commit 2bbd8c6 into main Sep 6, 2023
7 checks passed
@ss2165 ss2165 deleted the feat/symb-param branch September 6, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow pass-through of unsuported TKET1 op parameters in the decoder/encoder
2 participants