Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid special casing pi symbols #92

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: avoid special casing pi symbols #92

merged 1 commit into from
Sep 7, 2023

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Sep 6, 2023

TKET sometimes uses division by pi.
Avoid trying to parse this and just keep the string.

I'm a bit skeptical of parsing the division too, but will leave until it causes problems.

TKET sometimes uses division by pi.
Avoid trying to parse this and just keep the string.

I'm a bit skeptical of parsing the division too, but will leave until it causes problems.
@ss2165 ss2165 requested a review from lmondada September 6, 2023 16:20
Copy link
Contributor

@lmondada lmondada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ss2165 ss2165 merged commit 4048ff6 into main Sep 7, 2023
7 checks passed
@ss2165 ss2165 deleted the fix/pi-div branch September 7, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants