feat: Add RewriteStrategies #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lmondada
commented
Sep 12, 2023
lmondada
commented
- build: Update to latest Hugr rev bc9692b
- feat: Add RewriteStrategies
aborgna-q
approved these changes
Sep 13, 2023
src/rewrite/strategy.rs
Outdated
| @@ -0,0 +1,212 @@ | |||
| //! Rewriting strategies for circuit optimisation. | |||
| //! | |||
| //! This module contains the [`RewriteStrategy`] trait, which is implemented by | |||
There was a problem hiding this comment.
Something missing here?
src/rewrite.rs
Outdated
Comment on lines
65
to
67
| // Safety: pointer casting is allowed as Subcircuit is transparently | ||
| // just SiblingSubgrah. | ||
| unsafe { &*(self as *const SiblingSubgraph as *const Subcircuit) } |
There was a problem hiding this comment.
Uhm. This is ok, but I'd propose using bytemuck instead (it does essentially the same, but we sideload the unsafe to a really well tested crate that does extra checks).
#[derive(TransparentWrapper)]
#[repr(transparent)]
pub struct Subcircuit {...}
fn as_ref(&self) -> &Subcircuit {
Subcircuit::wrap_ref(self)
}There was a problem hiding this comment.
Awesome, I quickly googled for a crate that would do this but missed it, thanks for the pointer!
| /// to a circuit according to a strategy, returning a set of possible | ||
| /// optimised circuits. | ||
| pub trait RewriteStrategy { | ||
| /// Apply a set of rewrites to a circuit. |
There was a problem hiding this comment.
Clarify that each returned Hugr may have multiple non-overlapping rewrites elements applied to it.
src/rewrite/strategy.rs
Outdated
| ) -> Vec<Hugr>; | ||
| } | ||
|
|
||
| /// A rewrite strategy that applies as many rewrites as possible on one circuit. |
There was a problem hiding this comment.
I'd add something like
Suggested change
| /// A rewrite strategy that applies as many rewrites as possible on one circuit. | |
| /// A rewrite strategy that applies as many non-overlapping rewrites as possible | |
| /// on a single instance of the circuit. |
There was a problem hiding this comment.
I've expanded the docs a bit, hopefully it is clearer now.
src/rewrite/strategy.rs
Outdated
| .filter(|rw| { | ||
| let old_count = rw.subcircuit().node_count() as f64; | ||
| let new_count = rw.replacement().num_gates() as f64; | ||
| dbg!(old_count, new_count); |
There was a problem hiding this comment.
Suggested change
| dbg!(old_count, new_count); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.