Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front end validation #83

Merged
merged 5 commits into from
Oct 30, 2022
Merged

front end validation #83

merged 5 commits into from
Oct 30, 2022

Conversation

cookiedan42
Copy link
Contributor

@cookiedan42 cookiedan42 commented Oct 27, 2022

Overview

#78

Add front end validation for username and password

Main changes and their rationale(s)

  • followed style of text field validation error used in signup/login

Some considerations were y

imported the same checker from login, so we can set stricter rules and standardize

Things to take note of

  • user-service response was not standardized, so front end wasn't picking it up
  • used existing snackbar for error message
  • tldr snackbar for back end errors, text box for front end validation error

Testing

e.g. Simply run:

cypress <some file>.ts

image

@cookiedan42
Copy link
Contributor Author

image
image

@@ -27,6 +27,7 @@ export const ENV_IS_PROD = process.env.ENV == 'PROD'
*/
export const CORS_OPTIONS: cors.CorsOptions = {
credentials: true,
// origin: '*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this?

@tanyjnaaman tanyjnaaman merged commit b0b2824 into main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants