Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain Python3.8 #276

Merged
merged 6 commits into from
Apr 17, 2023
Merged

Maintain Python3.8 #276

merged 6 commits into from
Apr 17, 2023

Conversation

Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Apr 17, 2023 •
edited
Loading

Changes

  • Reinstates that Python3.8 is supported, adjust static types
  • Re-adds Python3.8 to workflows
  • Fixes a potential error that can happen with performing forecast analysis without fiona installed
  • Pins pip below v23.1 as the newest changes deprecate --install-options

More Information

pypa/pip#11358

@Zeitsperre Zeitsperre self-assigned this Apr 17, 2023
@Zeitsperre Zeitsperre added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 17, 2023
@Zeitsperre Zeitsperre changed the title Maintain py38 Maintain Python3.8 Apr 17, 2023
@Zeitsperre Zeitsperre requested a review from huard April 17, 2023 19:44
huard
huard approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci !

@Zeitsperre Zeitsperre merged commit 408e557 into master Apr 17, 2023
@Zeitsperre Zeitsperre deleted the maintain_py38 branch April 17, 2023 19:55
@tlvu
Copy link
Collaborator

tlvu commented Apr 17, 2023

Moi aussi, merci !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @tlvu @huard