Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config API and Options Screen Redesign #2837

Open
wants to merge 52 commits into
base: dev
Choose a base branch
from
Open

Config API and Options Screen Redesign #2837

wants to merge 52 commits into from

Conversation

douira
Copy link
Collaborator

@douira douira commented Oct 24, 2024 •
edited
Loading

Also thanks to @KingContaria for writing code on which I based the forge mod config entrypoint loader. @IMS212 wrote the initial redesign of the options page.

There's a bunch of TODOs in the code that I want to address. Feel free to help me with them and I'll merge them into this PR.

The design of the page as well as the outwards facing API are open to feedback and remain subject to change until release.

fixes #867
fixes #2309
fixes #2831
fixes #2976

@douira douira mentioned this pull request Oct 27, 2024
Merged
@douira
Copy link
Collaborator Author

douira commented Nov 3, 2024

After implementing dynamic value constraints in the slider and cycler control elements, the remaining TODOs are not necessary for the basic required features to work and it's ready for review. The requests for additions to the API were implemented.
The search bar is not yet functional, but we can simply remove that without regressing the UX and add it when it gets implemented later. @KingContaria mentioned he wanted to work on the tooltip scroller and I plan on slowly working through the other remaining non-essential TODOs, which are related to UX/UI.
One thing I can't do and should be clarified before we release, is the automatic import of vanilla options into our options screen that @IMS212 had prototyped. I don't have that code but would integrate it if provided with it.

@douira douira marked this pull request as ready for review November 3, 2024 04:16
@douira douira requested a review from jellysquid3 November 3, 2024 04:16
@douira
Copy link
Collaborator Author

douira commented Nov 26, 2024

I've been provided by IMS's code to import vanilla options but haven't worked through that yet. @KingContaria contributed scrollable tooltips and I further reworked tooltip and donation button rendering.

@jellysquid3 jellysquid3 added this to the Sodium 0.7 milestone Dec 12, 2024
IMS212 and others added 21 commits January 1, 2025 18:36
@IMS212 @douira
New game GUI experiment
7dc0b7e
@douira
Add WIP config api with IMS' redesign of the options page and contari…
e18b1e1 
…a's forge mod entrypoint loader code
@douira
scrollabe page list
009dfd7 
authored by @KingContaria
@douira
allow users to set their own theme colors,
dd9737e 
fix some issues when text is too long
@douira
add api to add custom screens, use a color theme builder instead of a…
4c8123b 
… direct method
@douira
move important members of option builder subinterfaces more useful
c82bd60
@douira
refactor: store dimensions in AbstractWidget
3927bed 
Co-authored-by: contaria <[email protected]>
@douira
new: scrollable option list
005e8b0 
Co-authored-by: contaria <[email protected]>
@douira
fix: move sliders and tickboxes when sccrolling
d988311 
Co-authored-by: contaria <[email protected]>
@douira
add api method for formatting version instead of setting a new one
e16eeb7
@douira
fix crash not working correctly
04498d2
@douira
move layout constants into separate class,
51dc8f4 
fix gradient behind sidebar,
change layout of buttons and options panes,
fix overlapping ui elements,
fix scissor areas,
make spacings and arrangement consistent
@douira
constrain tooltip to screen
5601db4
@douira
fix tooltip after rebase
b04bfad
@douira
improve config failure crash message
d2fb51c
@douira
add default implementation to early register entrypoint so users don'…
2ed1259 
…t need to implement both entrypoints even if they only need the late ("main") one
@douira
truncate mod header subtitles if too long
86dfc40
@douira
add usage documentation, update todos
2e9be38
@douira
add api methods to add button that redirects to an external page
a1a86bd
@douira
allow gui scale to be changed by holding down control and scrolling,
e7b1c82 
refactor option applying, move flag processing into Config,
@douira
add ability for mods to override other mods' options with new options
d1ae9e1
haykam821 and others added 22 commits January 1, 2025 18:37
@haykam821 @douira
Fix cycling controls not playing a sound when activated using the key…
18f3769 
…board

fixes CaffeineMC#2309
@douira
allow changing fullscreen resolution on macOS too
b70d6b3 
fixes CaffeineMC#2831
@KingContaria @douira
new: make tooltips scrollable
f54b256
@douira
consolidate more colors into the color class
bef3089
@douira
misc cleanup and refactor scrollbar widget to extend abstract widget
327a8dd
@douira
add arrow to toolbar at hovered element, moved tooltip logic into own…
57c77d6 
… class, moved donation button logic into own class, refactored layout
@douira
update todos
1a6a355
@douira
move builder impls into separate package
471f923
@douira
add page list width constant
81a2e58
@douira
add search index interface and bigram search index implementation
f4a4907
@douira
move search button to top of page list
e341aa0
@douira
add search widget that turns search button into a text box with a clo…
1c11929 
…se button,

other refactoring around page and option list layouts
@douira
remove search result class and move score into text source,
335be86 
this simplifies a number of operations around the search result processing.
also added more context to the text source objects
@douira
make page list highlight more visible
9d3278d
@douira
make the search results actually ordered
c022107
@douira
use option page instead of just page as the metadata on text sources …
f2f71e5 
…from options
@douira
use abstract option list instead of concrete option list where possible
5140879
@douira
add search results with page list and clickable page list items
dfb3845
@douira
fix some focus issues with the search box
92f9bdb
@douira
fix merge issues
68b6799
@douira
fix compact donation button functionality
9ca3924
@douira
fix focus behavior on search bar
53b1c12
@douira douira mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jellysquid3 jellysquid3 Awaiting requested review from jellysquid3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sodium 0.7
5 participants
@douira @jellysquid3 @IMS212 @haykam821 @KingContaria