Asynchronous Render List Generation and Frame-Independent Task Scheduling #2887

douira · 2024-11-22T20:00:25Z

Uses an octree to generate render lists independently of the, now asynchronous, slow graph search.

It runs the occlusion culler in a separate thread, which allows a large speedup in render list generation time. Correct culling results are ensured with a combination of different types of BFS, synchronous occlusion culling is used as a last resort if the camera teleports or moves extremely quickly.
Tasks are ordered based on a combination score of how long they've been pending, their distance from the camera, their type, and whether they're visible in the camera frustum. How many tasks can be scheduled is now independent of the frame rate and instead are limited based on their estimated duration and size.
There's an upload limit to ensure not too many tasks are submitted that will exceed the upload buffer's size. This isn't a hard limit and this PR doesn't implement a new way of handling task buffers, to avoid expanding the scope too far.

Testing has not shown regressions and generally frame rate has improved a little if a system was not limited by render list generation, and a lot if it was. (see testing thread)

Companion PR in Iris: IrisShaders/Iris#2539

…led yet, it just does the tree frustum test right after each bfs for testing purposes atm)

…g RenderSection objects, improve tree render list generation performance

…the tree, this greatly improves performance

…learer code

…ync bfs if there is very fast movement

…trees of varying accuracy to present as few sections as possible while not generating any errors when the camera is in motion.

… unloading of chunks

…ssues when the distance changes (for example under water)

- rebuild tasks are scheduled in a queue and pruned each frame - async culling tasks and results are classes in their own package - chunk rebuild tasks are prioritized based on their distance to the camera, their type, how long the task has been pending, and whether the section is currently visible (in the frustum) - generally cleaned up the update method in RSM

… not automatically correctly ordered since they're not coming from a tree � Conflicts: � common/src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/lists/VisibleChunkCollectorAsync.java

…her issues with (at least vertical) sorting though and even important zero-frame blocking tasks are not scheduled within the same frame

…tum task list update

…fallback and for use in iris. Now that there's a fallback, we don't need to accept using invalid trees if there's no other trees available. fix tree isValid test for wide trees. rename the trees field on RSM since it's misleading (it's actually forests, and they're cull results)

…parate from regular deferred task scheduling

tree traversal only does correct in-region sorting, not between regions

…matrix to avoid very long tail of camera changes after player movement

…k tree and updating the section's pending tasks by storing and then later catching up the tree with the changes

…speedy scheduling of nearby section tasks

…function

… render into one method, fix bugs with disappearing entities and not rendered newly non-empty sections by refactoring is present code in SectionTree to use a predicate that checks for section emptiness

…flag from MC to "playerChanged" for clarity, don't schedule tasks as important if they're no longer in range and schedule tasks during cull task even if they're important to make sure tasks that were downgraded in importance are still processed eventually

… world load

…sion, this improves scheduling accuracy and doesn't allow the estimator to get biased by fast tasks on small sections

…it in 1.21.2 Signed-off-by: douira <[email protected]>

…sync tasks whenever possible, only perform out of graph fallback when really out of graph Signed-off-by: douira <[email protected]>

Signed-off-by: douira <[email protected]>

This was referenced Nov 22, 2024

Integration with Asynchronous Render List Generation in Sodium IrisShaders/Iris#2539

Draft

Sort render lists for regions and sections after traversal (#2266) #2780

Merged

douira force-pushed the decoupled-frustum-test branch from 94885b5 to 158cd78 Compare November 25, 2024 19:12

douira added the T-enhancement Type: Enhancement label Nov 26, 2024

douira force-pushed the decoupled-frustum-test branch from 1ad3a3f to f969cbb Compare November 27, 2024 22:35

jellysquid3 added this to the Sodium 0.7 milestone Dec 2, 2024

douira force-pushed the decoupled-frustum-test branch from ecdd040 to df32670 Compare December 7, 2024 22:31

douira added 23 commits December 31, 2024 05:39

documentation cleanup

c74e536

do frustum cull using a linear octree, WIP (BFS isn't actually decoup…

308c2d1

…led yet, it just does the tree frustum test right after each bfs for testing purposes atm)

use faster deinterleave with one fewer steps

91bec56

implement front-to-back ordering during tree traversal

5516d55

refactor plumbing between RSM and the chunk renderer to avoid touchin…

859de49

…g RenderSection objects, improve tree render list generation performance

filter out sections that don't render anything before adding them to …

aadd330

…the tree, this greatly improves performance

change tree read timing to average 100 samples

a30a055

doesn't need to be public anymore

ee883f4

more reasonable flag mask ordering

eecee40

take 2000 samples for measurement

7041f5d

fix entity culling

0061a95

split node iteration into separate loops, no change in performance, c…

a51a624

…learer code

use section coordinates for tree compatibility test

f6d6b1a

remove unnecessary frustum test from entity culling

1af1779

refactor update state management in RSM, add option to fall back to s…

9f99785

…ync bfs if there is very fast movement

add better async bfs and tree management. It now calculates multiple …

dfbc3f4

…trees of varying accuracy to present as few sections as possible while not generating any errors when the camera is in motion.

prevent some NPEs that happen because of concurrency with loading and…

b016c29

… unloading of chunks

comment

50ab595

increase tasks per thread per frame to 3, this seems to usually be ok

918a241

do render distance and fog culling in the tree traversal to prevent i…

7b94588

…ssues when the distance changes (for example under water)

don't do frustum bfs if the frame was dirty to prevent unnecessary work

61b8c99

remove debug changes

1f4f0d8

douira added 12 commits December 31, 2024 05:39

sort render lists separately when doing sync rendering, since they're…

48f9bef

… not automatically correctly ordered since they're not coming from a tree � Conflicts: � common/src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/lists/VisibleChunkCollectorAsync.java

remove completed todos

9cdc97c

fix some issues with very delayed section sorting. There are still ot…

5d85cda

…her issues with (at least vertical) sorting though and even important zero-frame blocking tasks are not scheduled within the same frame

fix sorting by using correct section pos calculation and improve frus…

0794387

…tum task list update

add documentation and rename some methods

9ed5432

cleanup some todos

bea59e7

count tasks using ints instead of longs

c0e46dd

put task list collection into its own file

25892ef

move exponential moving average to the math util file

07f02cd

fix synchronous sort tasks, change important task scheduling to be se…

816bde2

…parate from regular deferred task scheduling

add region sorting to fix translucency sorting issues,

9c44397

tree traversal only does correct in-region sorting, not between regions

douira force-pushed the decoupled-frustum-test branch from 29caa4b to 9c44397 Compare December 31, 2024 04:41

douira added 7 commits January 2, 2025 06:22

use small delta instead of strict equality when comparing projection …

4c05162

…matrix to avoid very long tail of camera changes after player movement

prevent estimator from corrupting its data with Infinity

d1b52cf

fix forgotten chunk updates stemming from concurrently building a tas…

ee34902

…k tree and updating the section's pending tasks by storing and then later catching up the tree with the changes

split important and defer mode in the chunk update type to allow for …

57ee0b1

…speedy scheduling of nearby section tasks

rename updateCameraState to something more descriptive of its actual …

b587263

…function

adjust pending task scheduling time priority factor

b8cf0e7

consolidate tests that check whether a render section has anything to…

0877d04

… render into one method, fix bugs with disappearing entities and not rendered newly non-empty sections by refactoring is present code in SectionTree to use a predicate that checks for section emptiness

douira mentioned this pull request Jan 3, 2025

Fix Culling if Origin is in an Unloaded Section #2893

Closed

douira added 9 commits January 4, 2025 03:30

update job duration factor faster to keep up with JVM warmup at first…

33c0663

… world load

rewrite estimation code to split into 1d average and 2d linear regres…

3a02c45

…sion, this improves scheduling accuracy and doesn't allow the estimator to get biased by fast tasks on small sections

add correct debug presentation of the estimator models

b863dc8

improve naming of defer chunk updates option

053c5fc

fix max section bound for ray occlusion tree after Minecraft changed …

6ef53ee

…it in 1.21.2 Signed-off-by: douira <[email protected]>

make tree selection for rendering more robust and avoid waiting for a…

13f3a18

…sync tasks whenever possible, only perform out of graph fallback when really out of graph Signed-off-by: douira <[email protected]>

fix concurrent modification of tree hashmap

81301c5

Signed-off-by: douira <[email protected]>

fix tree index calculation and out of bounds cases with multi-forests

d0a3d18

Signed-off-by: douira <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Asynchronous Render List Generation and Frame-Independent Task Scheduling #2887

Asynchronous Render List Generation and Frame-Independent Task Scheduling #2887

douira commented Nov 22, 2024 •

edited

Loading

Asynchronous Render List Generation and Frame-Independent Task Scheduling #2887

Are you sure you want to change the base?

Asynchronous Render List Generation and Frame-Independent Task Scheduling #2887

Conversation

douira commented Nov 22, 2024 • edited Loading

douira commented Nov 22, 2024 •

edited

Loading