Use fit options from base fitter #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4946,3 +4946,25 @@ def test_should_raise_exception_if_cure_parameter_is_already_in_list_of_paramete | |||
| " Try something else instead.", | |||
| ): | |||
| MixtureCureFitter(MixtureCureFitter(base_fitter=ExponentialFitter())) | |||
|
|
|||
| def test_should_get_same_values_as_custom_weibull_on_kidney_transplant_data_set(self): | |||
| @@ -82,6 +82,7 @@ def __init__(self, base_fitter, *args, **kwargs): | |||
|
|
|||
| self._fitted_parameter_names = [self._CURED_FRACTION_PARAMETER_NAME] + base_fitter._fitted_parameter_names | |||
| self._bounds = [(0, 1)] + base_fitter._bounds | |||
| self._scipy_fit_options = base_fitter._scipy_fit_options | |||
|
Ignore the failing test, it's a config problem. Your test passes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MixtureCureFitter did not use the fit options of the base fitter. It should do so, so that it can take advantage of any necessary settings. The most obvious example of this is when the base_fitter=WeibullFitter - see new test for the rest.