Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Camera crop image activity is not removed #162

Closed
sapsalgea opened this issue Jul 16, 2021 · 4 comments · Fixed by #171
Closed

[BUG] - Camera crop image activity is not removed #162

sapsalgea opened this issue Jul 16, 2021 · 4 comments · Fixed by #171

Comments

@sapsalgea
Copy link

sapsalgea commented Jul 16, 2021

  • Lib Version: 3.2.1

youtube video

Steps to reproduce the behaviour:

  1. Open Camera
  2. Capture a Image
  3. Crop a image
  4. Open crop selector again
  5. Don't select any image
  6. return

Cropping photos from the gallery will not result in this.
this bug appears when after cropping with the camera .

After cropping with the camera, if you do not select an image from the gallery, the camera image result will continue to appear.

Actual Behaviour:

You can see your first cropped image

Expected behaviour:

You should close crop activity because you don't have a image selected

@sapsalgea sapsalgea added the bug label Jul 16, 2021
@Canato
Copy link
Member

Canato commented Jul 16, 2021

Interesting bug, never got in his case, but I know why this happen, we use the same file name to save cache memory of the device, so we don't create an image copy for every crop done.

Not an urgent bug, but for sure something would be nice to fix.

The fix will be something like this: (If someone has more time before myself)

  • After crop pressed, clean original URL parameter

@inossan-dev
Copy link

inossan-dev commented Jul 24, 2021

@Canato Please, how to clean original URL parameter ?

@Canato
Copy link
Member

Canato commented Jul 24, 2021

@Canato Please, how to clean original URL parameter ?

Not sure if this is possible. Need to check if original url is accessible (not on my computer today) we probably need a PR to improve this

@Canato
Copy link
Member

Canato commented Jul 26, 2021

Just check the code and we can't need some PR to improve it. Please feel free to drop a PR with a fix and we can discuss =D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants