Do not crop after pick cancelled #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test is rather low-level, but I believe I've confirmed using the Sample app that this indeed solves the user-level problem. |
|
This PR is beauty 🤩 Will check later today/tomorrow. |
Canato
requested changes
Jul 29, 2021
Canato
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #162
Bug
Cause:
After cropping a file is left on the file system for later use. The picker contract doesn't respect cancellation, so if it finds that file it will (incorrectly) return it for cropping even though the user intended to cancel file selection.
Reproduce
How the bug was solved:
Discussion on #162 suggested removing the file after cropping. However it seems to me that we can't know when to do this safely: because we return a URI to this file, we can't know whether the library's client has finished using it or not. Instead I made the picker contract explicitly respect cancellation: when cancelled, it returns no URI even if there is a file available.