-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hacktoberfest] - image pick option #226
Comments
Hey, I would like to work on this |
Thanks @jashasweejena feel free to start. |
Thank you @Canato :) ! |
Hi @Canato, I don't know how large the scope of this work will be. But I'll like to help out with this, or writing tests(unit/integration) |
Hey @Zikstar any help will be amazing! Try and let me know |
I've started working on it @Canato . Do you also want users to be able to specify where they want to pick from as part of CropImageContractOptions? That way in the CropImageActivity, its not a hardcoded value |
Yes @Zikstar nice approach, we probably need to update |
Cool I'll update that @Canato |
@jashasweejena can keep working, already saw some PRs that are open and after people find bugs they do not fix, because some stuffs in this library are hard. If one of you merge before the other, for sure we will have improvements from the second person to put on top of it! I believe we can bring a good solution together and everyone will be able to help and get some hactoberfest points ^^ |
Cool @Canato ^_^ |
Sorry for the messup @jashasweejena feel free to check what Zikstar already did and think about improvements or think in any of the other issues we have open Tests and documentation and never enough ^^ |
Sorry to barge in @jashasweejena. This is actually my first open-source contribution, and it's a library I'm familiar with and use at work. So I really wanted to contribute something |
@Canato How do I update wiki? Is that in the code or on github? |
@Zikstar sadly the wiki I have to do my self. =/// If you can just past here I will copy there. |
Basically, the code snippets on this page have to be update to these, that's all
|
I saw the PR before this comment, sorry.
We should not assume this if we can split 🤔 maybe using something more specific over |
So, just looked into mime types, its not possible to use anything more specific, because the results would be irrelevant to images. The other specific mime types are video/, text/, audio/. It has to be a subset. And I can reflect that in the variable names("includeAllDocuments and includeOnlyGallery"). And maybe the documentation can reflect that if you set includeAllDocuments to true, you don't need to set includeOnlyGallery. Another option would be to remove "includeAllDocuments" completely, because any relevant applications will always be caught by image/ anyway(Including file apps, I tested this). And includeDocuments is always set to false in the library anyway |
You have a fair point, I would go for the simple, let's remove |
Description
Today the user can use the library to pick images from camera, gallery or documents
But the user cannot select that is from camera only, for example. So we need to add a parameter to the contract that define which intents we will use for selection.
Possible solution:
PickImageContract
would receive a data class, like we have inCropImageContract
and this data class will contain booleans for each type of selection camera/gallery/etc in the case that if you only choose one it open directlyThe text was updated successfully, but these errors were encountered: