Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature for user to be able to pick image source #233

Merged
merged 11 commits into from
Oct 6, 2021

Conversation

Zikstar
Copy link
Contributor

@Zikstar Zikstar commented Oct 5, 2021

Issue 226

Description:

  • Added new data class for the user to specify the source to pick Image from
  • Added this class to pickImageContract and cropImageContract
  • Handled ripple effect of this change

Check list for the Code Reviewer:

  • CHANGELOG
  • README
  • Wiki
  • Version Number

@Zikstar Zikstar requested a review from a team as a code owner October 5, 2021 19:08
@Canato
Copy link
Member

Canato commented Oct 5, 2021

@Zikstar don't forget to read CONTRIBUTING

We will need changelog updates and a new session on README to explain how to use image picker

Copy link
Member

@Canato Canato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far, some small stuff to change

🎉

@Canato Canato linked an issue Oct 5, 2021 that may be closed by this pull request
@Zikstar
Copy link
Contributor Author

Zikstar commented Oct 5, 2021

New changes/commit made

Copy link
Member

@Canato Canato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically done, just one last bit

Amazing work

cropper/src/main/java/com/canhub/cropper/CropImage.kt Outdated Show resolved Hide resolved
@Zikstar
Copy link
Contributor Author

Zikstar commented Oct 6, 2021

New changes, includeDocument has been removed, reflected in the readMe example and javadoc comment

Copy link
Member

@Canato Canato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one no need file, we are almost merging !

.idea/deploymentTargetDropDown.xml Outdated Show resolved Hide resolved
@Canato
Copy link
Member

Canato commented Oct 6, 2021

@Zikstar the CI is broke, as soon it pass we can merge =D

@Zikstar
Copy link
Contributor Author

Zikstar commented Oct 6, 2021

@Zikstar the CI is broke, as soon it pass we can merge =D

How do I fix it? I've already ran ktLintFormat. The error messages are by Ktlint about deprecations in files I didn't touch

@Canato
Copy link
Member

Canato commented Oct 6, 2021

How do I fix it? I've already ran ktLintFormat. The error messages are by Ktlint about deprecations in files I didn't touch

Look like the error is a unit test

e: /home/runner/work/Android-Image-Cropper/Android-Image-Cropper/cropper/src/test/java/com/canhub/cropper/ContractTestFragment.kt: (32, 66): Type mismatch: inferred type is Boolean but PickImageContractOptions! was expected
Task :cropper:compileDebugUnitTestKotlin FAILED

Check the ContractTestFragment class

To run the tests locally you can type ./gradlew testDebugUnitTest in the terminal inside Android Studio

@Zikstar
Copy link
Contributor Author

Zikstar commented Oct 6, 2021

./gradlew testDebugUnitTest

Oh my bad. Should be fixed now

Copy link
Member

@Canato Canato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, really excited about this feature 🚀

@Zikstar
Copy link
Contributor Author

Zikstar commented Oct 6, 2021

Thanks, it was great working with you

@Canato Canato merged commit a8e07dc into CanHub:main Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hacktoberfest] - image pick option
2 participants