-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature for user to be able to pick image source #233
Add feature for user to be able to pick image source #233
Conversation
@Zikstar don't forget to read CONTRIBUTING We will need changelog updates and a new session on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far, some small stuff to change
🎉
cropper/src/main/java/com/canhub/cropper/PickImageContractOptions.kt
Outdated
Show resolved
Hide resolved
cropper/src/main/java/com/canhub/cropper/PickImageContractOptions.kt
Outdated
Show resolved
Hide resolved
New changes/commit made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically done, just one last bit
Amazing work
New changes, includeDocument has been removed, reflected in the readMe example and javadoc comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one no need file, we are almost merging !
…into feature/pick_image_contract_options merge from main
…com/Zikstar/Android-Image-Cropper into feature/pick_image_contract_options merge from my branch
@Zikstar the CI is broke, as soon it pass we can merge =D |
How do I fix it? I've already ran ktLintFormat. The error messages are by Ktlint about deprecations in files I didn't touch |
Look like the error is a unit test
Check the To run the tests locally you can type |
Oh my bad. Should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, really excited about this feature 🚀
Thanks, it was great working with you |
Issue 226
Description:
Check list for the Code Reviewer: