136 fix get fragmentactivity from contextwrapper #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure that Jobs get canceled only by their start method. What will happen if someone call Sorry i did not write earlier, i didnt had time yesterday. |
|
@WMariusz good point, I expected they will not leak because if you call again will generate a new scope and a new job or will override it. I will check the flow on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #136
Bug
Cause:
android.view.ContextThemeWrapper cannot be cast to androidx.fragment.app.FragmentActivityReproduce
GIVEN: Version 3.1.1 of the library, view have attibute
android:themeWHEN: using
CropImageView.setImageUriAsync()methodTHEN: method try to cast
ContextThemeWrappertoFragmentActivityHow the bug was solved:
Change the WorkerJobs to use the
Contextand for the thread we create aCoroutineScopeinside the class