Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crop always return uri (Gradle 7.0, Java 11, Android 12) #185

Merged
merged 6 commits into from
Sep 1, 2021
Merged

Crop always return uri (Gradle 7.0, Java 11, Android 12) #185

merged 6 commits into from
Sep 1, 2021

Conversation

Canato
Copy link
Member

@Canato Canato commented Aug 16, 2021 •
edited
Loading

close #180

Description:

This PR will make the library always return the result into URI content, making easy for the users understand the behaviour.
(To be complete with more information)

Check list for the Code Reviewer:

  • CHANGELOG
  • README
  • Wiki
  • Version Number

@Canato Canato mentioned this pull request Aug 16, 2021
Closed
@Canato Canato force-pushed the always_return_uri branch from 7bb8ab3 to 53a987a Compare August 16, 2021 19:18
@Canato Canato mentioned this pull request Aug 25, 2021
Closed
@Canato Canato linked an issue Aug 25, 2021 that may be closed by this pull request
Can't import on Gradle version 7.0.1 #191
Closed
@stale
Copy link

stale bot commented Aug 30, 2021

Let's keep this mess organised! This issue has been automatically marked as stale because it has not had recent activity. =( It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 30, 2021
@Canato
Copy link
Member Author

Canato commented Aug 31, 2021

Relax Stale bot, I was in holidays, will resume this work soon.

@stale stale bot removed the stale label Aug 31, 2021
@Canato Canato marked this pull request as ready for review September 1, 2021 18:30
@Canato Canato requested a review from a team as a code owner September 1, 2021 18:30
@Canato Canato changed the title WIP - Always return uri Crop always return uri (Gradle 7.0, Java 11, Android 12) Sep 1, 2021
@Canato Canato force-pushed the always_return_uri branch 4 times, most recently from 3febddb to 82000b6 Compare September 1, 2021 19:08
@Canato Canato merged commit 72078ed into main Sep 1, 2021
@Canato Canato deleted the always_return_uri branch September 1, 2021 19:16
@Canato Canato mentioned this pull request Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't import on Gradle version 7.0.1 [BUG] - Getting uriContent as null in CropImageView.CropResult
1 participant
@Canato