Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.0.0 #275

Merged
merged 13 commits into from
Nov 30, 2021
Merged

Release 4.0.0 #275

merged 13 commits into from
Nov 30, 2021

Conversation

Canato
Copy link
Member

@Canato Canato commented Nov 24, 2021 •
edited
Loading

close #271
close #253
close #274

Todo List

  • CHANGELOG
  • README
  • Version Number
  • Update min version following Android deprecated versions
  • Remove all permissions needs for getting pictures, using Activity Contract
  • Remove previous deprecated methods
  • Remove pick image contract
  • Improve image source selection layout

CHANGELOG

Fixed

  • Issue where some devices based on MIUI would not retrieve image from gallery #253

Changed

  • minSdkVersion = 16, previous versions have been deprecated by Google.

Removed

  • Pick Image, now the library will handle this without expose the contract #271
  • Need for READ_EXTERNAL_STORAGE permission #271
  • Previous deprecated ActivityBuilder, startPickImageActivity, getActivityResult and onActivityResult #145

@Canato Canato requested a review from a team as a code owner November 24, 2021 22:01
@Canato Canato self-assigned this Nov 24, 2021
@Canato Canato force-pushed the 271-read-files-without-permission branch from 5e245cb to 5ee2f30 Compare November 26, 2021 17:39
@aliaksandr-chaulytka
Copy link

=)
I am waiting for this update 👍

@Canato
Copy link
Member Author

Canato commented Nov 28, 2021

=) I am waiting for this update 👍 CC: @aliaksandr-chaulytka

Working on this now, close to finish a stable version. Will need a lot of tests hope can count with everyone ^^

@Canato
Copy link
Member Author

Canato commented Nov 28, 2021

This version should be working, but I'm not happy with the AlertDialog design.

Planning to change this into a BottomSheet format.

@Canato Canato force-pushed the 271-read-files-without-permission branch from 7bafd88 to 38df145 Compare November 28, 2021 14:36
@Canato Canato changed the title [WIP] - Release 4.0.0 Release 4.0.0 Nov 28, 2021
Canato
Canato commented Nov 28, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt Outdated Show resolved Hide resolved
@aliaksandr-chaulytka
Copy link

Really great and fast work, #274 fixed!! Thanks 👍

@Canato Canato mentioned this pull request Nov 30, 2021
Closed
@Canato Canato merged commit bf2c5b4 into main Nov 30, 2021
@Canato Canato deleted the 271-read-files-without-permission branch November 30, 2021 16:18
@Canato Canato mentioned this pull request Nov 30, 2021
Closed
4 tasks
@Canato Canato mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Canato Canato

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Canato @aliaksandr-chaulytka